Skip to content

fix: build with Go 1.26.10 for the eMudhra CA distrust - #37

Merged
zzwong merged 1 commit into
mainfrom
zzwong/go-1.26.10-toolchain
Oct 21, 2026
Merged

zzwong merged 1 commit into
mainfrom
zzwong/go-1.26.10-toolchain

Conversation

@zzwong

@zzwong zzwong commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Add toolchain go1.26.10 to every Go module so CI and release builds use Go 1.26.10. Go 1.26.10 and 1.27.3 add a crypto/x509 distrust of the compromised eMudhra intermediate keys (CVE-2026-111943), which applies whatever root store the binary verifies against. Binaries built with earlier releases still accept certificates issued through those keys on Linux, where verification uses the system roots.

actions/setup-go uses the toolchain directive in preference to the go directive, so builds, tests and releases all pick it up. The go language version is unchanged.

Verification

GOTOOLCHAIN=go1.26.10 go build ./... passes for every module.

@monit-reviewer monit-reviewer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: 9895acab6a66
Profile: claude-monit-reviewer - Posting as: monit-reviewer

Summary

Reviewer Findings
automation:ci-release 0
go:implementation-tests 0
policies:conventions 0
structure:repo-health 0

Reviewer Coverage

  • automation:ci-release — complete (broad); skipped: none; constraints: Only go.mod was assigned; workflow files were checked only via grep for go-version-file usage.
  • go:implementation-tests — complete (broad); skipped: none; constraints: Change is a two-line toolchain directive in go.mod; no Go code or tests changed. Did not run a build with GOTOOLCHAIN=go1.26.10.
  • policies:conventions — complete (broad); skipped: none; constraints: Shared cli-common docs were not available in context; review limited to the repo checkout and diff.
  • structure:repo-health — complete (broad); skipped: none; constraints: Only go.mod was assigned; workflow files were checked only by grep to confirm they read go-version-file from go.mod. The repo has a single module and no go.work.
Inspected files (1)
  • go.mod

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 3m 24s | ~$0.91 (est.) | claude-sonnet-5-5 | cr 0.10.325
Field Value
Model claude-sonnet-5-5
Reviewers automation:ci-release, go:implementation-tests, policies:conventions, structure:repo-health
Engine claude_cli · claude-sonnet-5-5
Reviewed by cr · monit-reviewer
Duration 3m 24s wall · 7m 17s compute
Cost ~$0.91 (est.)
Pricing basis baseline-2026-10-02/pricing
Tokens 44 in / 5.2k out

Per-workstream usage

  • orchestrator-selection — claude-sonnet-5-5
    • In: 4
    • Out: 665
    • Cache read: 9.2k
    • Cache create: 35.5k
    • Cost: ~$0.15 (est.)
    • Duration: 15s
  • automation:ci-release — claude-sonnet-5-5
    • In: 8
    • Out: 954
    • Cache read: 93.1k
    • Cache create: 19.9k
    • Cost: ~$0.11 (est.)
    • Duration: 1m 38s
  • go:implementation-tests — claude-sonnet-5-5
    • In: 8
    • Out: 864
    • Cache read: 93.6k
    • Cache create: 20.0k
    • Cost: ~$0.11 (est.)
    • Duration: 1m 13s
  • policies:conventions — claude-sonnet-5-5
    • In: 10
    • Out: 1.2k
    • Cache read: 103.7k
    • Cache create: 31.9k
    • Cost: ~$0.16 (est.)
    • Duration: 1m 31s
  • structure:repo-health — claude-sonnet-5-5
    • In: 8
    • Out: 1.1k
    • Cache read: 73.5k
    • Cache create: 32.2k
    • Cost: ~$0.16 (est.)
    • Duration: 1m 32s
  • orchestrator-rollup — claude-sonnet-5-5
    • In: 6
    • Out: 439
    • Cache read: 95.9k
    • Cache create: 51.1k
    • Cost: ~$0.23 (est.)
    • Duration: 1m 06s

@zzwong
zzwong marked this pull request as ready for review October 21, 2026 00:48
@zzwong
zzwong merged commit 931aa82 into main Oct 21, 2026
11 checks passed
@zzwong
zzwong deleted the zzwong/go-1.26.10-toolchain branch October 21, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants